Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Do not use static certificates for diagnose tests into release/1.18.x #29126

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #29122 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

The below text is copied from the body of the original PR.


Description

The static x509 certificate is expiring Jan 6 2025 and is now causing test failures within the diagnose test cases.

Instead of just reissuing the certificate and having to deal with this in the future, codify the generation of certificates and test cases that we want to validate so the certificates will never expire again.

For time reasons, I haven't fixed all the test cases, mainly the ones that were causing issues for now.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/stevendpclark/fix-diagnose-tests-with-expired-cert/ideally-civil-monkey branch from dd3e29a to 32f4de3 Compare December 9, 2024 13:03
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 9, 2024
@victorr victorr added this to the 1.18.3 milestone Dec 9, 2024
Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@victorr victorr enabled auto-merge (squash) December 9, 2024 13:04
Copy link

github-actions bot commented Dec 9, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Dec 9, 2024

Build Results:
All builds succeeded! ✅

@victorr victorr merged commit 79d55dc into release/1.18.x Dec 9, 2024
83 of 84 checks passed
@victorr victorr deleted the backport/stevendpclark/fix-diagnose-tests-with-expired-cert/ideally-civil-monkey branch December 9, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants